Hi Adrian, On 28.08.2017 02:53, Adrian.Danis@data61.csiro.au wrote:
Hi Alex,
I think this is a good direction to move in, and supporting MBI2 definitely makes sense. In an ideal world, yes we would try and cut out grub2 and be pure UEFI booted, but given current resources I cannot see that happening any time soon, and so I see no reason not to welcome MBI2 support.
As you point out some of the code itself is not perfect, but what it's actually doing seems fairly simple and non-controversial to me. Quite possibly you did this just to get it working as a proof of concept, but I would discourage adding more architecture information to the raw seL4_Bootinfo (the archInfo word is an old hack), and instead use the additional headers (https://github.com/seL4/seL4/blob/master/libsel4/include/sel4/bootinfo_types...). Aside from that, as you say the code needs some deduplication etc, but I'm happy to continue on github and get this in.
ok, created a github issue at https://github.com/seL4/seL4/issues/67 -- Alexander Boettcher Genode Labs http://www.genode-labs.com - http://www.genode.org Genode Labs GmbH - Amtsgericht Dresden - HRB 28424 - Sitz Dresden Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth