[seL4] Re: libsel4utils: load_segment memory leak bug

Hi wzt,

i found a bug memory leak bug in libsel4utils/src/elf.c

static int load_segment(vspace_t *loadee_vspace, vspace_t *loader_vspace, vka_t *loadee_vka, vka_t *loader_vka, const char *src, size_t file_size, int num_regions, sel4utils_elf_region_t regions[num_regions], int region_index) { seL4_CPtr loader_slot; cspacepath_t loader_frame_cap;

 error = vka_cspace_alloc(loader_vka, &loader_slot);  // [1]
 while (pos < segment_size && error == seL4_NoError) {
     reservation_t reservation;
     if (loadee_vaddr < region.reservation_vstart) {
         if ((region_index - 1) < 0) {
             ZF_LOGE("Invalid regions: bad elf file.");
             return 1; // [2]
         }

}

if [2] happned, it not free the prev alloc memory, and then it's memory will be leaked. i think the correct way is invoke vka_cspace_free() before return.

Indeed, This looks like a bug. Could you create an issue at https://github.com/seL4/seL4_libs/issues and in case you already have a patch to fix this, also create a pull request there?

Axel